feat: support svg elements #60
Merged
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoloJiang
approved these changes
Apr 21, 2022
ChrisCindy
approved these changes
Apr 21, 2022
SoloJiang
added a commit
that referenced
this pull request
Apr 26, 2022
* feat: support svg elements (#60) * feat: support svg elements * chore: fix lint and add notes * feat(compiler): update structure in get template method * fix(compiler): lint error * feat(compiler): use handler to distinguish events and on props * chore(compiler): add EventAttributeDescriptor interface Co-authored-by: Rongyan Chen <[email protected]> Co-authored-by: 狒狒神 <[email protected]>
SoloJiang
added a commit
that referenced
this pull request
May 11, 2022
* refactor: runtime structure * chore: lint * feat: support element template diff * chore: lint * feat(compiler): update structure in get template method (#62) * feat: support svg elements (#60) * feat: support svg elements * chore: fix lint and add notes * feat(compiler): update structure in get template method * fix(compiler): lint error * feat(compiler): use handler to distinguish events and on props * chore(compiler): add EventAttributeDescriptor interface Co-authored-by: Rongyan Chen <[email protected]> Co-authored-by: 狒狒神 <[email protected]> * feat: html method support new structure * feat: html method support new structure * fix(compiler): inject wrong value in runtime compiler * refactor: reactive node * chore: test case * fix(compiler): replace values with templateData in template result * chore: test case * chore: add test case * refactor: base render * chore: revert code * chore: test case * chore: lint * chore: ts type * chore: test case * chore: add comment * chore: remove useless comment * chore: add test case * chore: optimize code * chore: optimize code * chore: link * chore: optimize code Co-authored-by: NK <[email protected]> Co-authored-by: Rongyan Chen <[email protected]> Co-authored-by: 逆葵 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://svgwg.org/svg2-draft/struct.html#InterfaceSVGSVGElement
Svg elements properties are read only, must be set as attributes